Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump tap_core to v3 #592

Merged
merged 2 commits into from
Jan 29, 2025
Merged

chore: bump tap_core to v3 #592

merged 2 commits into from
Jan 29, 2025

Conversation

gusinacio
Copy link
Member

@gusinacio gusinacio commented Jan 29, 2025 •
edited
Loading

Signed-off-by: Gustavo Inacio [email protected]

  • remove dead code in tap-agent/value.rs

@github-actions GitHub Actions
Copy link
Contributor

Pull Request Test Coverage Report for Build 13033919083

Details

  • 44 of 46 (95.65%) changed or added relevant lines in 15 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 78.11%
Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/service/src/error.rs 1 2 50.0%
crates/tap-agent/src/agent/sender_allocation.rs 8 9 88.89%
Files with Coverage Reduction New Missed Lines %
crates/service/src/error.rs 1 60.0%
Totals Coverage Status
Change from base Build 12995438616: 0.2%
Covered Lines: 6958
Relevant Lines: 8908
💛 - Coveralls

suchapalaver
suchapalaver approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@suchapalaver suchapalaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@gusinacio gusinacio merged commit 236fefe into main Jan 29, 2025
10 checks passed
@gusinacio gusinacio deleted the gustavo/bump-tap-core-v3 branch January 29, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suchapalaver suchapalaver suchapalaver approved these changes

@carlosvdr carlosvdr Awaiting requested review from carlosvdr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gusinacio @suchapalaver